Refactor errors #118

zemanlx · 2019-10-10T14:36:38Z

I was looking at the codebase and thinking if I can make some part a bit nicer. Here is my first attempt.

I have:

added unit tests for ErrorFilter function to lock behaviour and be sure later that I am not changing it.
removed dead code
refactored ErrorFilter function to
- return early
- avoid else as much as possible
- not duplicate work
- decrease number of indented code
- decrease brain buffer when reading code flow

I can do more PRs like this one if you find it useful.

rsp.Response == nil checked and modified earlier

so that it is possible to return early and remove else branches

and have less indented code.

NewResponse duplicates action taken later in code.

zemanlx added 7 commits October 10, 2019 14:20

Lock current behaviour in unit tests

24ca5e8

Use named return variable

997fc0a

Remove unreachable branch

31b2231

rsp.Response == nil checked and modified earlier

Move empty error decorator to defer

de5c8b2

so that it is possible to return early and remove else branches

Invert ifs to return early

5823207

and have less indented code.

Remove unused status2TerrCode()

f4b59dc

Remove creation of NewResponse in request error case

9c794c0

NewResponse duplicates action taken later in code.

Provide feedback